Apply code review fixes: validation, error handling, and cleanup #5

Merged

deco merged 4 commits from code-review-fixes into main

2026-02-03 19:55:06 +02:00

deco commented

2026-02-03 19:54:01 +02:00

Owner

Summary

Add broadcast message length validation (max 4000 chars)
Add tryAcquireLock/releaseLock to prevent broadcast race conditions
Wrap member tracking in try/catch for error resilience
Remove redundant idx_sessions_key index (PRIMARY KEY already indexed)
Improve logging for corrupted session cleanup
Consolidate getErrorMessage into shared utils/errors.ts module

Test plan

All 102 tests pass
TypeScript builds without errors

🤖 Generated with Claude Code

## Summary - Add broadcast message length validation (max 4000 chars) - Add tryAcquireLock/releaseLock to prevent broadcast race conditions - Wrap member tracking in try/catch for error resilience - Remove redundant idx_sessions_key index (PRIMARY KEY already indexed) - Improve logging for corrupted session cleanup - Consolidate getErrorMessage into shared utils/errors.ts module ## Test plan - [x] All 102 tests pass - [x] TypeScript builds without errors 🤖 Generated with [Claude Code](https://claude.ai/code)

deco added 4 commits

2026-02-03 19:54:01 +02:00

Log rate-limited command attempts 3cc4e9855c

Track rate limit violations in database 36395b04ad

- New rate_limit_violations table (user_id, username, first_name, command, timestamp)
- SqliteAdapter methods: recordRateLimitViolation, getRateLimitViolationCount,
  getTopRateLimitAbusers, getRecentViolations, getTotalViolationCount, cleanupOldViolations
- New /abusers admin command with time period filter (24h, 7d, 30d, all)
- Middleware now records violations to DB in addition to console logging

Add automatic cleanup of old rate limit violations on startup 9c06f01eb4

- Configurable via RATE_LIMIT_CLEANUP_DAYS (default: 30 days)
- Runs alongside session cleanup on bot start

Apply code review fixes: validation, error handling, and cleanup

CI / test (pull_request) Successful in 43s

Details

884b002c47

- Add broadcast message length validation (max 4000 chars)
- Add tryAcquireLock/releaseLock to prevent broadcast race conditions
- Wrap member tracking in try/catch for error resilience
- Remove redundant idx_sessions_key index (PRIMARY KEY already indexed)
- Improve logging for corrupted session cleanup
- Consolidate getErrorMessage into shared utils/errors.ts module

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>