signal-works/ice
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fix S3 upload: remove ACL parameters for bucket without ACL support

Browse source 
- Removed --acl public-read parameters from GitHub Action
- S3 bucket policy handles public access instead of ACLs
- Should resolve AccessControlListNotSupported error
This commit is contained in:
Deco Vander 2025-07-03 00:11:08 -04:00
parent 5b9c9f7396
commit 2cda43edc9
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
.github/workflows/deploy-scripts.yml vendored
View file

@ -31,7 +31,6 @@ jobs:
run: | run: |
# Upload the main deployment script # Upload the main deployment script
aws s3 cp scripts/deploy.sh s3://${{ secrets.S3_BUCKET_NAME }}/scripts/deploy.sh \ aws s3 cp scripts/deploy.sh s3://${{ secrets.S3_BUCKET_NAME }}/scripts/deploy.sh \
--acl public-read \
--content-type "text/plain" \ --content-type "text/plain" \
--cache-control "max-age=300" \ --cache-control "max-age=300" \
--metadata-directive REPLACE \ --metadata-directive REPLACE \
@ -39,13 +38,11 @@ jobs:
# Upload systemd service file # Upload systemd service file
aws s3 cp scripts/icewatch.service s3://${{ secrets.S3_BUCKET_NAME }}/scripts/icewatch.service \ aws s3 cp scripts/icewatch.service s3://${{ secrets.S3_BUCKET_NAME }}/scripts/icewatch.service \
--acl public-read \
--content-type "text/plain" \ --content-type "text/plain" \
--cache-control "max-age=3600" --cache-control "max-age=3600"
# Upload Caddyfile # Upload Caddyfile
aws s3 cp scripts/Caddyfile s3://${{ secrets.S3_BUCKET_NAME }}/scripts/Caddyfile \ aws s3 cp scripts/Caddyfile s3://${{ secrets.S3_BUCKET_NAME }}/scripts/Caddyfile \
--acl public-read \
--content-type "text/plain" \ --content-type "text/plain" \
--cache-control "max-age=3600" --cache-control "max-age=3600"