Standardize screen position naming to snake_case

- Update screen position naming from camelCase to snake_case (top_left, top_right, bottom_left, bottom_right)
- Refactor getActive route to use SCREEN_POSITIONS constant for DRY code
- Update documentation to reflect new file naming convention
- Remove unnecessary console.log for internal network requests in middleware
- Improve code maintainability and consistency across the codebase

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

app/api/getActive/route.ts

@@ -1,6 +1,7 @@
 import fs from 'fs';
 import path from 'path';
 import { createSuccessResponse, createErrorResponse, withErrorHandling } from '../../../lib/apiHelpers';
+import { SCREEN_POSITIONS } from '../../../lib/constants';
 
 const FILE_DIRECTORY = path.resolve(process.env.FILE_DIRECTORY || './files')
 // Ensure directory exists
@@ -11,31 +12,17 @@ console.log('using',  FILE_DIRECTORY)
 
 async function getActiveHandler() {
     try {
-        const largePath = path.join(FILE_DIRECTORY, 'large.txt');
-        const leftPath = path.join(FILE_DIRECTORY, 'left.txt');
-        const rightPath = path.join(FILE_DIRECTORY, 'right.txt');
-        const topLeftPath = path.join(FILE_DIRECTORY, 'topLeft.txt');
-        const topRightPath = path.join(FILE_DIRECTORY, 'topRight.txt');
-        const bottomLeftPath = path.join(FILE_DIRECTORY, 'bottomLeft.txt');
-        const bottomRightPath = path.join(FILE_DIRECTORY, 'bottomRight.txt');
+        const activeSources: Record<string, string | null> = {};
 
-        const large = fs.existsSync(largePath) ? fs.readFileSync(largePath, 'utf-8').trim() : null;
-        const left = fs.existsSync(leftPath) ? fs.readFileSync(leftPath, 'utf-8').trim() : null;
-        const right = fs.existsSync(rightPath) ? fs.readFileSync(rightPath, 'utf-8').trim() : null;
-        const topLeft = fs.existsSync(topLeftPath) ? fs.readFileSync(topLeftPath, 'utf-8').trim() : null;
-        const topRight = fs.existsSync(topRightPath) ? fs.readFileSync(topRightPath, 'utf-8').trim() : null;
-        const bottomLeft = fs.existsSync(bottomLeftPath) ? fs.readFileSync(bottomLeftPath, 'utf-8').trim() : null;
-        const bottomRight = fs.existsSync(bottomRightPath) ? fs.readFileSync(bottomRightPath, 'utf-8').trim() : null;
+        // Read each screen position file using the constant
+        for (const screen of SCREEN_POSITIONS) {
+            const filePath = path.join(FILE_DIRECTORY, `${screen}.txt`);
+            activeSources[screen] = fs.existsSync(filePath) 
+                ? fs.readFileSync(filePath, 'utf-8').trim() 
+                : null;
+        }
 
-        return createSuccessResponse({
-            large,
-            left,
-            right,
-            topLeft,
-            topRight,
-            bottomLeft,
-            bottomRight
-        });
+        return createSuccessResponse(activeSources);
     } catch (error) {
         console.error('Error reading active sources:', error);
         return createErrorResponse('Failed to read active sources', 500, 'Could not read source files', error);

docs/OBS_SETUP.md

@@ -17,10 +17,10 @@ You must create **exactly 7 Source Switcher sources** in OBS with these specific
 | `ss_large` | Main/Large screen | `large.txt` |
 | `ss_left` | Left screen | `left.txt` |
 | `ss_right` | Right screen | `right.txt` |
-| `ss_top_left` | Top left corner | `topLeft.txt` |
-| `ss_top_right` | Top right corner | `topRight.txt` |
-| `ss_bottom_left` | Bottom left corner | `bottomLeft.txt` |
-| `ss_bottom_right` | Bottom right corner | `bottomRight.txt` |
+| `ss_top_left` | Top left corner | `top_left.txt` |
+| `ss_top_right` | Top right corner | `top_right.txt` |
+| `ss_bottom_left` | Bottom left corner | `bottom_left.txt` |
+| `ss_bottom_right` | Bottom right corner | `bottom_right.txt` |
 
 ## Setup Instructions
 

lib/constants.ts

@@ -45,10 +45,10 @@ export const SCREEN_POSITIONS = [
     'large',
     'left', 
     'right',
-    'topLeft',
-    'topRight',
-    'bottomLeft',
-    'bottomRight'
+    'top_left',
+    'top_right',
+    'bottom_left',
+    'bottom_right'
 ] as const;
 
 export const SOURCE_SWITCHER_NAMES = [

lib/security.ts

@@ -1,6 +1,6 @@
 // Security utilities for input validation and sanitization
 
-export const VALID_SCREENS = ['large', 'left', 'right', 'topLeft', 'topRight', 'bottomLeft', 'bottomRight'] as const;
+export const VALID_SCREENS = ['large', 'left', 'right', 'top_left', 'top_right', 'bottom_left', 'bottom_right'] as const;
 export type ValidScreen = typeof VALID_SCREENS[number];
 
 // Input validation functions

middleware.ts

@@ -21,10 +21,6 @@ export function middleware(request: NextRequest) {
     // Skip authentication for localhost/internal requests (optional security)
     const host = request.headers.get('host');
     if (host && (host.startsWith('localhost') || host.startsWith('127.0.0.1') || host.startsWith('192.168.'))) {
-      // Don't log for frequently polled endpoints to reduce noise
-      if (!request.nextUrl.pathname.includes('/api/obsStatus')) {
-        console.log('Allowing internal network access without API key');
-      }
       return NextResponse.next();
     }