Standardize screen position naming to snake_case
All checks were successful
Lint and Build / build (pull_request) Successful in 2m46s
All checks were successful
Lint and Build / build (pull_request) Successful in 2m46s
- Update screen position naming from camelCase to snake_case (top_left, top_right, bottom_left, bottom_right) - Refactor getActive route to use SCREEN_POSITIONS constant for DRY code - Update documentation to reflect new file naming convention - Remove unnecessary console.log for internal network requests in middleware - Improve code maintainability and consistency across the codebase 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
parent
2bb0c64326
commit
a89fa7c8d6
7 changed files with 4393 additions and 1607 deletions
|
@ -1,6 +1,7 @@
|
|||
import fs from 'fs';
|
||||
import path from 'path';
|
||||
import { createSuccessResponse, createErrorResponse, withErrorHandling } from '../../../lib/apiHelpers';
|
||||
import { SCREEN_POSITIONS } from '../../../lib/constants';
|
||||
|
||||
const FILE_DIRECTORY = path.resolve(process.env.FILE_DIRECTORY || './files')
|
||||
// Ensure directory exists
|
||||
|
@ -11,31 +12,17 @@ console.log('using', FILE_DIRECTORY)
|
|||
|
||||
async function getActiveHandler() {
|
||||
try {
|
||||
const largePath = path.join(FILE_DIRECTORY, 'large.txt');
|
||||
const leftPath = path.join(FILE_DIRECTORY, 'left.txt');
|
||||
const rightPath = path.join(FILE_DIRECTORY, 'right.txt');
|
||||
const topLeftPath = path.join(FILE_DIRECTORY, 'topLeft.txt');
|
||||
const topRightPath = path.join(FILE_DIRECTORY, 'topRight.txt');
|
||||
const bottomLeftPath = path.join(FILE_DIRECTORY, 'bottomLeft.txt');
|
||||
const bottomRightPath = path.join(FILE_DIRECTORY, 'bottomRight.txt');
|
||||
const activeSources: Record<string, string | null> = {};
|
||||
|
||||
const large = fs.existsSync(largePath) ? fs.readFileSync(largePath, 'utf-8').trim() : null;
|
||||
const left = fs.existsSync(leftPath) ? fs.readFileSync(leftPath, 'utf-8').trim() : null;
|
||||
const right = fs.existsSync(rightPath) ? fs.readFileSync(rightPath, 'utf-8').trim() : null;
|
||||
const topLeft = fs.existsSync(topLeftPath) ? fs.readFileSync(topLeftPath, 'utf-8').trim() : null;
|
||||
const topRight = fs.existsSync(topRightPath) ? fs.readFileSync(topRightPath, 'utf-8').trim() : null;
|
||||
const bottomLeft = fs.existsSync(bottomLeftPath) ? fs.readFileSync(bottomLeftPath, 'utf-8').trim() : null;
|
||||
const bottomRight = fs.existsSync(bottomRightPath) ? fs.readFileSync(bottomRightPath, 'utf-8').trim() : null;
|
||||
// Read each screen position file using the constant
|
||||
for (const screen of SCREEN_POSITIONS) {
|
||||
const filePath = path.join(FILE_DIRECTORY, `${screen}.txt`);
|
||||
activeSources[screen] = fs.existsSync(filePath)
|
||||
? fs.readFileSync(filePath, 'utf-8').trim()
|
||||
: null;
|
||||
}
|
||||
|
||||
return createSuccessResponse({
|
||||
large,
|
||||
left,
|
||||
right,
|
||||
topLeft,
|
||||
topRight,
|
||||
bottomLeft,
|
||||
bottomRight
|
||||
});
|
||||
return createSuccessResponse(activeSources);
|
||||
} catch (error) {
|
||||
console.error('Error reading active sources:', error);
|
||||
return createErrorResponse('Failed to read active sources', 500, 'Could not read source files', error);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue